Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zero bucket boundary to default explicit bucket histogram #4819

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

jack-berg
Copy link
Member

Resolves #4665.

@jack-berg jack-berg requested a review from a team October 5, 2022 19:58
@jack-berg jack-berg force-pushed the explicit-histogram-buckets branch from bbe3f01 to d0871e7 Compare October 5, 2022 20:06
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 90.79% // Head: 90.78% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d0871e7) compared to base (caa441d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4819      +/-   ##
============================================
- Coverage     90.79%   90.78%   -0.01%     
  Complexity     4839     4839              
============================================
  Files           554      554              
  Lines         14422    14422              
  Branches       1402     1402              
============================================
- Hits          13094    13093       -1     
  Misses          910      910              
- Partials        418      419       +1     
Impacted Files Coverage Δ
...ernal/aggregator/ExplicitBucketHistogramUtils.java 100.00% <100.00%> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 92.41% <0.00%> (-0.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 25, 2022
@jack-berg jack-berg removed the Stale label Oct 25, 2022
@jack-berg
Copy link
Member Author

@jkwatson please take a look when you have a chance

@jack-berg jack-berg merged commit 21d5597 into open-telemetry:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default bucket boundaries for explicit bucket histogram are different from specification
4 participants