fix(graphql): graphql instrumentation throw for sync calls #1254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@opentelemetry/instrumentation-graphql
Error when running synchronously #1082The issue is that graphql resolvers can either be a promise or a sync function. Instrumentation wrapped each result with a promise (using
asyncSafeExecuteInTheMiddle
) which was confusing graphql, making it fail for sync runs, and changing the span times in a way that doesn't make sense (sync calls now overlapped).Short description of the changes
I added test and run
test-all-versions
on the PR