Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @opentelemetry/instrumentation v0.47.0 #1911

Closed
pebo opened this issue Jan 22, 2024 · 2 comments · Fixed by #1914
Closed

Support @opentelemetry/instrumentation v0.47.0 #1911

pebo opened this issue Jan 22, 2024 · 2 comments · Fixed by #1914

Comments

@pebo
Copy link

pebo commented Jan 22, 2024

Installing the latest (0.34.1) contrib package @opentelemetry/instrumentation-express and then installing the latest experimental @opentelemetry/instrumentation (0.47.0) gives two versions of @opentelemetry/instrumentation: 0.46.0 and 0.47.0

To reproduce:

yarn add @opentelemetry/instrumentation
yarn add @opentelemetry/instrumentation-express
yarn why @opentelemetry/instrumentation
├─ @opentelemetry/instrumentation-express@npm:0.34.1
│  └─ @opentelemetry/instrumentation@npm:0.46.0 (via npm:^0.46.0)
│
├─ @opentelemetry/instrumentation-express@npm:0.34.1 [f27bd]
│  └─ @opentelemetry/instrumentation@npm:0.46.0 [d2aea] (via npm:^0.46.0 [d2aea])
│
└─ otel@workspace:.
   └─ @opentelemetry/instrumentation@npm:0.47.0 [f27bd] (via npm:^0.47.0 [f27bd])

As I understand it the caret (^) in the express-instrumentation package dependency below only allows patch updates (e.g. to version 0.46.1 , 0.46.2 etc as the version starts with 0.:

"@opentelemetry/instrumentation": "^0.46.0"

Are there specific dependencies on "@opentelemetry/instrumentation": "^0.46.0" from @opentelemetry/instrumentation-express or can the constraint be relaxed or extended to "^0.46.0 || "^0.47.0" to avoid getting duplicated packages due to incompatible version constraints?

@pichlermarc
Copy link
Member

We've discovered a problem with 0.47.0 downstream dependencies that in certain cases causes the end-user's application to crash. (see #1905, open-telemetry/opentelemetry-js#4441)

Therefore, we will not support 0.47.0 and jump directly to 0.48.0 once it's released (open-telemetry/opentelemetry-js#4442)

@pebo
Copy link
Author

pebo commented Jan 26, 2024

Thanks for a quick and detailed response! Will upgrade our otel lib versions when @opentelemetry/instrumentation-express picks the new 0.48.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants