Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(host-metrics): make host metrics constructor options optional #2300

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Fixes #2274

Short description of the changes

  • Fields of MetricsCollectorConfig should all be optional.
  • Remove unused option fields.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (dfb2dff) to head (15745f5).
Report is 174 commits behind head on main.

Current head 15745f5 differs from pull request most recent head 6a07fdc

Please upload reports for the commit 6a07fdc to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
- Coverage   90.97%   90.30%   -0.68%     
==========================================
  Files         146      147       +1     
  Lines        7492     7263     -229     
  Branches     1502     1509       +7     
==========================================
- Hits         6816     6559     -257     
- Misses        676      704      +28     
Files Coverage Δ
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 100.00% <100.00%> (ø)

... and 58 files with indirect coverage changes

@legendecas
Copy link
Member Author

legendecas commented Jun 26, 2024

Reverted removal on

name: '', // to get default instrumentation scope name
to keep the empty name test.

@pichlermarc pichlermarc added the bug Something isn't working label Jun 27, 2024
@pichlermarc pichlermarc merged commit 16bff40 into open-telemetry:main Jun 27, 2024
22 checks passed
@dyladan dyladan mentioned this pull request Jun 27, 2024
@legendecas legendecas deleted the host-metrics-type branch June 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:host-metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible incorrect type in HostMetrics
2 participants