-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instr-mongodb): fix function patch missing one argument introduced in v6.8.0 #2314
Merged
david-luna
merged 6 commits into
open-telemetry:main
from
david-luna:dluna/2309-mongodb-command-issue
Jul 3, 2024
Merged
fix(instr-mongodb): fix function patch missing one argument introduced in v6.8.0 #2314
david-luna
merged 6 commits into
open-telemetry:main
from
david-luna:dluna/2309-mongodb-command-issue
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
==========================================
- Coverage 90.97% 90.42% -0.55%
==========================================
Files 146 148 +2
Lines 7492 7323 -169
Branches 1502 1518 +16
==========================================
- Hits 6816 6622 -194
- Misses 676 701 +25
|
pichlermarc
changed the title
fix(instr-mongodb): fix function patch missing one argument introduced in v6.6.0
fix(instr-mongodb): fix function patch missing one argument introduced in v6.8.0
Jul 3, 2024
pichlermarc
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-luna thanks for working on this. The fix looks good, just a few nits from my side. 👍
plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb-v5-v6.test.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb-v5-v6.test.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb-v5-v6.test.ts
Outdated
Show resolved
Hide resolved
…b-v5-v6.test.ts Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
…b-v5-v6.test.ts Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
…b-v5-v6.test.ts Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
trentm
approved these changes
Jul 3, 2024
Merged
Closed
5 tasks
timokoessler
added a commit
to AikidoSec/firewall-node
that referenced
this pull request
Jul 12, 2024
hansott
added a commit
to AikidoSec/firewall-node
that referenced
this pull request
Jul 15, 2024
…spaces * 'workspaces' of github.com:AikidoSec/node-RASP: fix opentelemetry test open-telemetry/opentelemetry-js-contrib#2314 Update lockfile fix missing packages Revert "Try to fix end2end tests" Try to fix end2end tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Which problem is this PR solving?
mongodb@6.8.0
introduced a new feature for lazy parsing documents. This feature relies on a new parameter on an internal API that the instrumentation was not passing to the original method resulting in an exception being thrown. Ref: #2309this PR contains a fix to make sure the
command
original API gets all parameters when called. It usesFunction.prototype.apply
to call the original function so we do not stump on the same issue if any other param is added.Short description of the changes
Function.prototype.apply
to not lose any parameters when calling the original API