Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-sdk): sns-sqs extract the correct context key from message payload #761

Merged
merged 17 commits into from
Nov 30, 2021

Conversation

habmic
Copy link
Contributor

@habmic habmic commented Nov 28, 2021

Which problem is this PR solving?

  • When using SNS to SQS integration and 'raw messages' are off, it searches for the propagation context in the wrong field.

Short description of the changes

  • it used to search only for StringValue now it will also look for Value

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #761 (e295fe3) into main (0463f27) will decrease coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   96.87%   96.37%   -0.50%     
==========================================
  Files          11       26      +15     
  Lines         640     1767    +1127     
  Branches      126      231     +105     
==========================================
+ Hits          620     1703    +1083     
- Misses         20       64      +44     
Impacted Files Coverage Δ
...emetry-instrumentation-aws-sdk/src/services/sns.ts 93.33% <0.00%> (ø)
...etry-instrumentation-aws-sdk/test/dynamodb.test.ts 100.00% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts 87.09% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 89.65% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.29% <0.00%> (ø)
...ry-instrumentation-aws-sdk/test/aws-sdk-v3.test.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 96.91% <0.00%> (ø)
...etry-instrumentation-aws-sdk/test/testing-utils.ts 100.00% <0.00%> (ø)
...ry-instrumentation-aws-sdk/test/aws-sdk-v2.test.ts 100.00% <0.00%> (ø)
... and 5 more

@blumamir blumamir changed the title Fix/sns sqs context propagation fix(aws-sdk): sns-sqs extract the correct context key from message payload Nov 28, 2021
@blumamir blumamir merged commit e5cae76 into open-telemetry:main Nov 30, 2021
@dyladan dyladan mentioned this pull request Feb 28, 2022
@dyladan dyladan mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants