Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load grpc in OTEL grpc exporters #4151

Closed
Flarna opened this issue Sep 15, 2023 · 4 comments · Fixed by #4432
Closed

Lazy load grpc in OTEL grpc exporters #4151

Flarna opened this issue Sep 15, 2023 · 4 comments · Fixed by #4432
Assignees
@pichlermarc
Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@Flarna
Copy link
Member

Flarna commented Sep 15, 2023

Followup on #4145

To avoid issues with init/instrumentation sequence OTLP grpc exporter should load grpc lazy (e.g. on first export).
@Flarna Flarna added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 21, 2023
@pichlermarc pichlermarc added bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect and removed up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 8, 2023
@pichlermarc pichlermarc self-assigned this Nov 8, 2023
@pichlermarc
Copy link
Member

Self-assigning as I'm working on this as part of a exporter-rewrite.

@pichlermarc pichlermarc mentioned this issue Nov 8, 2023
Closed
@ZRainc
Copy link

ZRainc commented Nov 22, 2023

Hi，I would like to ask when this bug will be fixed？

@pichlermarc
Copy link
Member

@ZRainc I'm planning for this to land next month.
Due to various reasons, exporters are currently hard to work with. I'll soon open PRs that will re-structure them in a way that makes it easier to fix bugs and add features. The bugfix will then follow these PRs.

@ZRainc
Copy link

ZRainc commented Nov 22, 2023

@ZRainc I'm planning for this to land next month.

Due to various reasons, exporters are currently hard to work with. I'll soon open PRs that will re-structure them in a way that makes it easier to fix bugs and add features. The bugfix will then follow these PRs.

Sounds Great, Thanks

@pichlermarc pichlermarc mentioned this issue Nov 30, 2023
Closed
This was referenced Jan 17, 2024
Closed
Merged
@pichlermarc pichlermarc mentioned this issue Feb 5, 2024
Open
@pichlermarc pichlermarc mentioned this issue Apr 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pichlermarc pichlermarc

Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(exporter-*-otlp-grpc)!: lazy load gRPC dynatrace-oss-contrib/opentelemetry-js
3 participants
@Flarna @pichlermarc @ZRainc