Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the specification of allocation strategy configuration in collector CRD #1105

Closed
jaronoff97 opened this issue Sep 16, 2022 · 2 comments
Labels
area:target-allocator Issues for target-allocator

Comments

@jaronoff97
Copy link
Contributor

The target allocator now has two methods of allocation (least-weighted, and consistent-hashing) the next strategy will be a composite strategy that will only assign targets post relabeling. All of these strategies have some amount of configuration to them, we should allow users of the TA to specify them in the CRD.

This also will allow us to have strategies as typed and not just strings in the CRD. The change will involve passing the spec containing the TA config down to each allocation strategy rather than just a logger as it stands right now.

Original discussion here

@swiatekm
Copy link
Contributor

@jaronoff97 this can be closed, right?

@jaronoff97
Copy link
Contributor Author

yep 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator
Projects
None yet
Development

No branches or pull requests

3 participants