Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MaxReplicas and MinReplicas to AutoscalerSpec in collector CRD #1115

Closed
moh-osman3 opened this issue Sep 20, 2022 · 2 comments · Fixed by #1302
Closed

Move MaxReplicas and MinReplicas to AutoscalerSpec in collector CRD #1115

moh-osman3 opened this issue Sep 20, 2022 · 2 comments · Fixed by #1302
Labels
area:collector Issues for deploying collector help wanted Extra attention is needed

Comments

@moh-osman3
Copy link
Contributor

In #1077, an Autoscaler field and object was added to the collector CRD. MaxReplicas and MinReplicas are fields specific to autoscaling so that should be moved to the AutoscalerSpec, and the HPA source code should be refactored to reflect this.
@moh-osman3 moh-osman3 mentioned this issue Sep 20, 2022
Merged
@pavolloffay pavolloffay added the area:collector Issues for deploying collector label Sep 30, 2022
@pavolloffay
Copy link
Member

cc) @kevinearls

@pavolloffay pavolloffay added the help wanted Extra attention is needed label Sep 30, 2022
@pavolloffay
Copy link
Member

Also note that we can't remove fields from a published CRD. If we want to move things around we would have to do deprecation and support the deprecated options as well.

@moh-osman3 moh-osman3 mentioned this issue Dec 6, 2022
Merged
@moh-osman3 moh-osman3 mentioned this issue Aug 15, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:collector Issues for deploying collector help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HPA] Move maxReplicas and minReplicas to AutoscalerSpec moh-osman3/opentelemetry-operator
2 participants
@pavolloffay @moh-osman3