Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guideline] what if I don't set startTime for cumulative metric datapoint #237

Closed
hossain-rayhan opened this issue Nov 12, 2020 · 5 comments
Labels
area:data-model priority:p1 release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics

Comments

@hossain-rayhan
Copy link

We had a small discussion on todays Metrics SIG meeting. Adding here for better tracking.

It is recommended that for IntSum()/ Cumulative metrics, we should set the start time. So the open questions are-

[1] Do we want to make it a required field?
[2] What if I don't set the startTime in the receiver?
[3] What is a good value for this? Some receivers set the receiver_start_time. Does it sound good?

Tagging @andrewhsu @jmacd @bogdandrutu for visibility.

@andrewhsu
Copy link
Member

from the issue triage mtg today, seems like this issue should be moved to opentelemetry-proto repo

@bogdandrutu bogdandrutu transferred this issue from open-telemetry/opentelemetry-collector Nov 13, 2020
@andrewhsu andrewhsu added release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics priority:p1 labels Dec 11, 2020
@bogdandrutu
Copy link
Member

This is something that we need a decision. @jrcamp I think we discussed this.

@jrcamp
Copy link

jrcamp commented Jan 19, 2021

See #229

@jmacd
Copy link
Contributor

jmacd commented Mar 15, 2021

Closing this in favor of #229.

@jmacd jmacd closed this as completed Mar 15, 2021
@jmacd
Copy link
Contributor

jmacd commented Mar 15, 2021

(Thank you @hossain-rayhan!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model priority:p1 release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics
Projects
None yet
Development

No branches or pull requests

5 participants