diff --git a/instrumentation/opentelemetry-instrumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/utils.py b/instrumentation/opentelemetry-instrumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/utils.py index 4907031a75..f42bb42386 100644 --- a/instrumentation/opentelemetry-instrumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/utils.py +++ b/instrumentation/opentelemetry-instrumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/utils.py @@ -60,7 +60,12 @@ def set(self, carrier: textmap.CarrierT, key: str, value: str) -> None: if value: value = value.encode() - carrier.append((key, value)) + + if isinstance(carrier, list): + carrier.append((key, value)) + + if isinstance(carrier, dict): + carrier[key] = value _kafka_getter = KafkaContextGetter() diff --git a/instrumentation/opentelemetry-instrumentation-confluent-kafka/tests/test_instrumentation.py b/instrumentation/opentelemetry-instrumentation-confluent-kafka/tests/test_instrumentation.py index e9462d7898..527c3e7fe9 100644 --- a/instrumentation/opentelemetry-instrumentation-confluent-kafka/tests/test_instrumentation.py +++ b/instrumentation/opentelemetry-instrumentation-confluent-kafka/tests/test_instrumentation.py @@ -24,6 +24,8 @@ ProxiedProducer, ) +from opentelemetry.instrumentation.confluent_kafka.utils import KafkaContextSetter + class TestConfluentKafka(TestCase): def test_instrument_api(self) -> None: @@ -58,3 +60,14 @@ def test_instrument_api(self) -> None: consumer = instrumentation.uninstrument_consumer(consumer) self.assertEqual(consumer.__class__, Consumer) + + def test_context_setter(self) -> None: + context_setter = KafkaContextSetter() + + carrier_dict = {"key1": "val1"} + context_setter.set(carrier_dict, "key2", "val2") + self.assertGreaterEqual(carrier_dict.items(), {"key2": "val2".encode()}.items()) + + carrier_list = [("key1", "val1")] + context_setter.set(carrier_list, "key2", "val2") + self.assertTrue(("key2", "val2".encode()) in carrier_list)