Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address lint failures #127

Closed
codeboten opened this issue Nov 4, 2020 · 1 comment · Fixed by #131
Closed

Address lint failures #127

codeboten opened this issue Nov 4, 2020 · 1 comment · Fixed by #131
Labels
bug Something isn't working

Comments

@codeboten
Copy link
Contributor

During the shift of instrumentation and exporter packages to the contrib repo, some issues were found in the linting, see failures here:

https://github.com/open-telemetry/opentelemetry-python-contrib/runs/1349549074

See discussion in gitter: https://gitter.im/open-telemetry/opentelemetry-python?at=5fa1b98bbf955735eb595894

@codeboten codeboten added the bug Something isn't working label Nov 4, 2020
@NathanielRN
Copy link
Contributor

Specifically, this command in eachdist.py is the lint command that is failing. For some reason it says the items in the insturmentation/ package are not lint compliant, even though they were compliant when they were in the Core repo and this was directly brought over from the Contrib repo.

execute_args(
parse_subargs(
args, ("exec", "pylint {}", "--all", "--mode", "lintroots")
)
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants