Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide instrumentations a way to exclude_urls that is not using environment variables #375

Closed
cdvv7788 opened this issue Mar 18, 2021 · 3 comments

Comments

@cdvv7788
Copy link
Contributor

cdvv7788 commented Mar 18, 2021

https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py#L40

Is your feature request related to a problem?
I want to get the urls to exclude from somewhere else than environment variables.

Describe the solution you'd like
Providing an argument to exclude_urls, using as default _exclude_urls (generated from environment variable) should be an option for other setups.

Describe alternatives you've considered
The fastapi instrumentation just adds a middleware. I copied that method with the additional variable as input.

Additional context
This is a simple addition, in case it is up to consideration. I can send a PR if that is ok.

@owais
Copy link
Contributor

owais commented Apr 6, 2021

This is a simple addition, in case it is up to consideration. I can send a PR if that is ok.

@cdvv7788 Please feel free to send one or more :)

@ivergara
Copy link

Isn't this issue closed by #486?

@cdvv7788
Copy link
Contributor Author

That is correct. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants