Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a consistent way of recording exception and status of span #1301

Closed
lzchen opened this issue Oct 28, 2020 · 1 comment
Closed

Have a consistent way of recording exception and status of span #1301

lzchen opened this issue Oct 28, 2020 · 1 comment
Assignees
Labels
instrumentation Related to the instrumentation of third party libraries or frameworks release:required-for-ga To be resolved before GA release sdk Affects the SDK package.

Comments

@lzchen
Copy link
Contributor

lzchen commented Oct 28, 2020

Following #1282,

Find a consistent way of recording exceptions from spans and instrumentations.

Currently, we have this and this both of which are needed depending on how the user creates the span. We should find a consistent way for all instrumentations to a) set error status and description on an error if caught and b) call record_exception when any of these happen.

@lzchen lzchen added sdk Affects the SDK package. instrumentation Related to the instrumentation of third party libraries or frameworks release:required-for-ga To be resolved before GA release labels Oct 28, 2020
@Oberon00
Copy link
Member

Oberon00 commented Nov 3, 2020

When cleaning this up, also consider setting exception.escaped to True for record_exception, since in __exit__ we know that the exception escapes the span. See https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/exceptions.md#attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instrumentation Related to the instrumentation of third party libraries or frameworks release:required-for-ga To be resolved before GA release sdk Affects the SDK package.
Projects
None yet
Development

No branches or pull requests

2 participants