Exporters shouldn't have service name parameter

[srikanthccv]

Exporters jaeger, zipkin and opencensus accept an argument service_name but ideally they should rely on the Resource's service.name attribute from Tracer/Span to indicate the resource that produced the corresponding telemetry.

[dmarar]

@lonewolf3739 , pls assign this to me

[srikanthccv]

@dmarar I don't have permissions to assign. @lzchen / @codeboten can assign this to you.

[codeboten]

@dmarar assigned! thanks

[dmarar]

@lonewolf3739 , Just to clarify on the requirement:
consider the following export() function of jaeger:

def export(self, spans) -> SpanExportResult:
>       service_name = spans[0].resource.service.name if spans[0].resource  else None  #assuming that all spans in a batch will have same resource.service.name

        translator = Translate(spans)
        if self.transport_format == TRANSPORT_FORMAT_PROTOBUF:
>            pb_translator = ProtobufTranslator(**service_name**)
            jaeger_spans = translator._translate(pb_translator)
            batch = model_pb2.Batch(spans=jaeger_spans)
            request = PostSpansRequest(batch=batch)
....

[srikanthccv]

@dmarar
You can just get the resource from trace.get_tracer_provider() and populate service name and resource attributes.

it would look something like this

from opentelemetry import trace
from opentelemetry.sdk.resources import SERVICE_NAME

tracer_provider = trace.get_tracer_provider()
resource = tracer_provider.resource
svc_name = resource.attributes[SERVICE_NAME]

[lzchen]

Should we remove service.name from the constructors of exporters too?

[srikanthccv]

Should we remove service.name from the constructors of exporters too?

Yes, that's what I mentioned in the issue title, I hope that's conveying the same? We need to remove the service_name param and use the Resource attribute.

[dmarar]

@lonewolf3739 - I have created a draft PR 1669
As said i have made the changes to OpenCensus and Jaeger.
But from what i see , zipkin the changes are already in place.

I did not find any other place where the service_name is being used in exporters.
Could you please point out if any other places i have missed?

Thanks,
-Dilip M

[codeboten]

This was fixed by #1669