Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP gRPC exporter silently fails if scheme is not specified in endpoint #1801

Closed
dustyhorizon opened this issue Apr 26, 2021 · 2 comments · Fixed by #1806
Closed

OTLP gRPC exporter silently fails if scheme is not specified in endpoint #1801

dustyhorizon opened this issue Apr 26, 2021 · 2 comments · Fixed by #1806
Assignees
Labels
bug Something isn't working

Comments

@dustyhorizon
Copy link

dustyhorizon commented Apr 26, 2021

Issue arising from implementing #1771

Steps to reproduce
Supplying an remote collector hostname without scheme causes the OTLP exporter to silently not export spans.

parsed_url.netloc is an empty str if the scheme is not specified e.g. localhost:55680, this causes spans to not be exported to a remote collector as endpoint is empty.

What is the expected behavior?
Spans are correctly exported to remote collector via OTLP.

What is the actual behavior?
Spans are not exported to remote collector via OTLP.

Additional context
Per opentelemetry specs, it was written that the scheme must be specified in the endpoint; this library should either enforce that the scheme is supplied (fail hard if not) or assume a sane default (http?) for the purposes of using this library.

@dustyhorizon dustyhorizon added the bug Something isn't working label Apr 26, 2021
@codeboten codeboten self-assigned this Apr 27, 2021
@codeboten
Copy link
Contributor

Thanks for raising this issue. i did not expect url parse to set localhost in the scheme 😞

@ElementalWarrior
Copy link

For those who bump into issues with grpc exporting, you can set these environment variables for the grpc library that the exporter uses, and it will export things like the path its going to, etc.

GRPC_VERBOSITY=DEBUG
GRPC_TRACE=http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants