Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf 4.21.0 does not work with current generated opentelemetry-proto #2721

Closed
aabmass opened this issue May 26, 2022 · 2 comments
Closed
Labels
priority:p1 Issues that should be resolved in the upcoming release (except for zero-day hotfix release) proto

Comments

@aabmass
Copy link
Member

aabmass commented May 26, 2022

Someone on slack reported that protobuf 4.21.0 broke their OTLP exporter, with the cause being protocolbuffers/protobuf#10051. In the meantime, it looks like that protobuf version was yanked https://pypi.org/project/protobuf/4.21.0/ (I'm assuming for this reason).

It looks like opentelemetry-proto package has proto > 3.13.0 which allows 4.x releases.. we really should have it pinned to the major version 3 i.e. proto ~= 3.13. Either way, we will need to re-generate the protobuf messages for the new major version (see protocolbuffers/protobuf#10051 (comment))

@aabmass aabmass added priority:p1 Issues that should be resolved in the upcoming release (except for zero-day hotfix release) proto labels May 26, 2022
@aabmass
Copy link
Member Author

aabmass commented May 26, 2022

Since the version was release, I think the best action for the upcoming release is to pin to major version 3. Once protobuf unyanks or cuts a new release, we will need to regenerate and up the dependency to pin major version 4.

@aabmass
Copy link
Member Author

aabmass commented May 26, 2022

Dup of #2717

@aabmass aabmass closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p1 Issues that should be resolved in the upcoming release (except for zero-day hotfix release) proto
Projects
None yet
Development

No branches or pull requests

1 participant