-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement force_flush for span exporters #2872
Comments
I agree. On the other hand, how to enforce that the exporter implementation must have |
Can we just make |
Looks like we don't have the |
Good question. I'm not sure about the Pythonic preferred design principle but it seems like we only started implementing with |
From specs: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#forceflush
Flushing implementation is usually done by the span processor. This addition is just to be compliant with the specs. The only point of contention is if we make this an
abstractmethod
, it is a breaking change for anyone who is implementing their own span exporter. We probably shouldn't do this, even though it's fixing a "bug" since it is not spec compliant. Thoughts?The text was updated successfully, but these errors were encountered: