OTLP exporter pins opentelemetry-proto

[Yamakaky]

Both opentelemetry-exporter-otlp-proto-* packages have a hard == dependency pin on opentelemetry-proto instead of the softer ~= used for the other dependencies. This mix of ~= and == can break pip dependency resolution as it happened for me today.

Context:

• Dependency pinning between packages post 1.0 #1924
• opentelemetry-instrumentation pins opentelemetery-api version #2011

See:

• https://github.com/open-telemetry/opentelemetry-python/blob/v1.14.0/exporter/opentelemetry-exporter-otlp-proto-grpc/pyproject.toml#L33
• https://github.com/open-telemetry/opentelemetry-python/blob/v1.14.0/exporter/opentelemetry-exporter-otlp-proto-http/pyproject.toml#L32

I believe both these files should read "opentelemetry-proto ~= 1.14"

[srikanthccv]

How did it break pip dependency resolution?

[Yamakaky]

Hum, I first thought that the wrong version was installed, but I think this is a dependency specification problem. grpc requires sdk~=1.12 but it does https://github.com/open-telemetry/opentelemetry-python/blob/main/exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/metric_exporter/__init__.py#L35 which is introduced in 1.14.

In any case I believe the original report should still be fixed.

[srikanthccv]

The new proto definitions get added, and some get removed occasionally after deprecation https://github.com/open-telemetry/opentelemetry-proto, so we try to use newly generated files whenever possible and make sure to test them against the exporters' code. If are you reporting an incorrect min version requirement for SDK that's a valid point but I don't see a good reason why the proto package should be ~= it.

[ocelotl]

The way we update the opentelemetry-proto dependency in opentelemetry-exporter-otlp-proto-grpc is to make it point to the latest released version, so I think it would be the same to have use ~= or ==.

WDYT, @srikanthccv?

[srikanthccv]

I still don't understand what the author was referring to. How did it break the pip dependency resolution?

[Yamakaky]

I didn't keep the original error at hand, but I believe this was due to the sdk version problem for the grpc exporter. I'll close this and open another one.