Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit for possible recursion error in logging code #4261

Open
xrmx opened this issue Nov 8, 2024 · 0 comments
Open

Audit for possible recursion error in logging code #4261

xrmx opened this issue Nov 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@xrmx
Copy link
Contributor

xrmx commented Nov 8, 2024

What happened?

We recently fixed a recursion error in logging (#4255) switching a call from logging to warnings. We need to audit for this kind of issues to other part of the logging code.
We want to also evaluate if warnings is really the right abastraction because of integrations with the logging module that may lead to the same issue https://docs.python.org/3/library/logging.html#integration-with-the-warnings-module

Would you like to implement a fix?

None

@xrmx xrmx added the bug Something isn't working label Nov 8, 2024
@xrmx xrmx changed the title Revise possible recurions in logs code Revise possible recursion error in logging code Nov 8, 2024
@xrmx xrmx changed the title Revise possible recursion error in logging code Audit for possible recursion error in logging code Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant