Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: decide what to do for invalid arguments #14

Closed
fbogsany opened this issue Jul 11, 2019 · 1 comment
Closed

API: decide what to do for invalid arguments #14

fbogsany opened this issue Jul 11, 2019 · 1 comment
Labels
question Further information is requested

Comments

@fbogsany
Copy link
Contributor

I'm not sure what we should do for invalid arguments in the minimal implementation, and am somewhat torn on the issue.

I just wanted to point out that there is a proposal currently in PR form here: open-telemetry/opentelemetry-specification#153.

There seem to be various opinions as you read through the comments. This comment proposed a somewhat pragmatic approach of falling back to a default when an argument is invalid. Quote (from the comment)

Specific case: I do think using a null name for Span could fallback to using a default name, instead of throwing. Documenting it is nice, but providing defaults for these kind of things is a good alternative ;)

It might be too early to make a final call on how to deal exceptions in the minimal implementation, but we should keep an eye on that PR and the specification repo for guidance.

Originally posted by @mwear in https://github.com/open-telemetry/opentelemetry-ruby/diffs

@fbogsany fbogsany added the question Further information is requested label Sep 16, 2019
@fbogsany
Copy link
Contributor Author

We settled on removing most runtime checks #115 and adding a "strict mode" #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant