Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the fallback for service.name #518

Closed
fbogsany opened this issue Dec 14, 2020 · 0 comments · Fixed by #572
Closed

Implement the fallback for service.name #518

fbogsany opened this issue Dec 14, 2020 · 0 comments · Fixed by #572
Labels
spec-compliance Required for OpenTelemetry spec compliance

Comments

@fbogsany
Copy link
Contributor

open-telemetry/opentelemetry-specification#1269 defines a required fallback for service.name of "unknown_service:#{process.executable.name}" or "unknown_service" if the executable name is not available.

We do not presently provide a default in the Configurator. The Jaeger exporter defaults to 'unknown'.

We should implement the specified required fallback in Configurator and remove the default in the Jaeger exporter.

@fbogsany fbogsany added the spec-compliance Required for OpenTelemetry spec compliance label Dec 14, 2020
@fbogsany fbogsany added this to the RC milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-compliance Required for OpenTelemetry spec compliance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant