Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Span Attributes: http.url must not contain username / password #647

Closed
pellared opened this issue Mar 9, 2021 · 1 comment · Fixed by #648
Closed

HTTP Span Attributes: http.url must not contain username / password #647

pellared opened this issue Mar 9, 2021 · 1 comment · Fixed by #648
Assignees
@fbogsany
Labels
question Further information is requested

Comments

@pellared
Copy link
Member

pellared commented Mar 9, 2021

As is stated in the recent specification change :

http.url MUST NOT contain credentials passed via URL in form of https://username:password@www.example.com/. In such case the attribute's value should be https://www.example.com/
@fbogsany fbogsany added the question Further information is requested label Mar 9, 2021
@fbogsany fbogsany self-assigned this Mar 9, 2021
@fbogsany fbogsany mentioned this issue Mar 9, 2021
Merged
@fbogsany
Copy link
Contributor

fbogsany commented Mar 9, 2021

Thanks for the issue. I confirmed 2 of our instrumentations violate this requirement. I've pushed up tests in #648 and I'll work on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbogsany fbogsany

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove passwords from http.url open-telemetry/opentelemetry-ruby
2 participants
@fbogsany @pellared