Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OpenTracing compatibility shim #91

Closed
fbogsany opened this issue Sep 16, 2019 · 10 comments
Closed

Implement OpenTracing compatibility shim #91

fbogsany opened this issue Sep 16, 2019 · 10 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed stale

Comments

@fbogsany
Copy link
Contributor

No description provided.

@fbogsany fbogsany added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 16, 2019
@fbogsany fbogsany added this to the Alpha milestone Sep 16, 2019
@rdooley
Copy link
Contributor

rdooley commented Sep 16, 2019

👋 I'm your huckleberry.

Self link https://github.com/open-telemetry/opentelemetry-java/tree/master/opentracing_shim

@fbogsany fbogsany modified the milestones: Alpha v0.2, Alpha v0.3 Oct 25, 2019
@fbogsany fbogsany modified the milestones: Alpha v0.3, Alpha v0.4 Mar 12, 2020
@mwear mwear modified the milestones: Alpha v0.5, Alpha v0.6 Jun 4, 2020
@fbogsany fbogsany modified the milestones: Alpha v0.6, Beta Aug 27, 2020
@fbogsany
Copy link
Contributor Author

The initial PR is #108 , however I don't believe @rdooley has time to continue with this and the PR likely needs significant updates to account for drift in the API. I've removed the assignment & opened this up to other folks who might like to help out.

@fbogsany
Copy link
Contributor Author

Note also open-telemetry/opentelemetry-specification#768 adds clarity around requirements here.

@rdooley
Copy link
Contributor

rdooley commented Sep 21, 2020

The initial PR is #108 , however I don't believe @rdooley has time to continue with this and the PR likely needs significant updates to account for drift in the API. I've removed the assignment & opened this up to other folks who might like to help out.

That is exactly correct. Thank you for removing my assignment.

@fbogsany
Copy link
Contributor Author

Pushing this out until open-telemetry/opentelemetry-specification#768 is approved.

@fbogsany fbogsany modified the milestones: Beta v0.7, Beta v0.8 Sep 22, 2020
@johnnyshields
Copy link
Contributor

@fbogsany What's the real-world justification for this? Who is only supporting OpenTracing but not OpenTelemetry?

@fbogsany
Copy link
Contributor Author

fbogsany commented Dec 7, 2020

A compatibility shim is required by the spec, although that requirement is implicit for now. There’s a tracking issue here: open-telemetry/opentelemetry-specification#1174

@fbogsany fbogsany removed this from the Beta v0.10 milestone Jan 11, 2021
@tessus
Copy link

tessus commented Oct 26, 2021

@fbogsany I am a bit confused. This issue has been open since 2019 and it was labeled as good first issue. Then there was a PR, which you closed in favor of a new implementation, which did not exist and still does not exist.

Are you going to implement this, since it is a good first issue and also mentioned that this was a req by the spec?

@fbogsany
Copy link
Contributor Author

The implementation was stale and the author was no longer working on it. He agreed we should close it. It is still something we'd like to have but no one is actively working on it.

Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale label Apr 28, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed stale
Projects
None yet
Development

No branches or pull requests

5 participants