Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop include_trace_context parameter from Logs API/SDK #1132

Closed
lalitb opened this issue Jun 26, 2023 · 0 comments · Fixed by #1133
Closed

Drop include_trace_context parameter from Logs API/SDK #1132

lalitb opened this issue Jun 26, 2023 · 0 comments · Fixed by #1133

Comments

@lalitb
Copy link
Member

lalitb commented Jun 26, 2023

As per the specs changes - open-telemetry/opentelemetry-specification#3397, the include_trace_context argument should be removed from LoggerProvider::versioned_logger() method. If there is active context in current thread, the SDK should retrieve the trace-context from there, and populate it in LogRecord object.

@lalitb lalitb changed the title Drop include_trace_context parameter from Log API/SDK Drop include_trace_context parameter from Logs API/SDK Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant