-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service name should be mandatory for all configured resources. #1241
Comments
+1 |
But, a service resource is not required, so you don't necessarily get a
This should be in the SDK spec somewhere. |
Getting |
I think it would be best to require all SDKs to provide a reasonable default service name to exporters if there is none explicitly configured. For example, use the same as |
@tedsuo fyi |
From the SIG today: as many languages already provide fallback/default values for |
I would still propose a change to the spec saying:
Side note: I am somewhat skeptical about step 2. For example, in Java the binary name is java, and the startup class name could be a generic framework class. The mechanism must be smart enough to recognize those cases and not use generic names. In addition, using a framework specific name is not ideal either, since it could be different from what is known as "service" to the orchestration, service discovery, and routing infrastructure. It's the latter that's the most useful as the service name for telemetry. |
I think a generic framework name is still better than "unknown_service" so while it would be nice if it was smarter, I don't think its very important. |
perhaps you're right |
Re-opening this, as it has been made less clear over time. |
With the discussion around #1294, this is now my opinion:
|
Ping @Oberon00 ;) |
I think we should specify how/when Jaeger/Zipkin should use the default resource's attribute. |
@Oberon00 Would mind elaborating? (else, you could help cook a PR yourself if you have enough cycles this week). |
Oh, actually there is a separate issue for that: #1237. I think I'll close this then, since I was the only one objecting to closing. |
What are you trying to achieve?
The resource specifications currently allow the entire
service.*
namespace to be missing from a Resource configured into the SDK. This means that exporters that require aservice.name
must be configured (or hard-coded) with a fallback name. Since all services should have aservice.name
, we should simply require that to be set on any resource that is attached to an SDK.Additional context.
This came up via the following spec clarification request for how the Jaeger exporter should behave in the absence of a
service.name
in the Resource: #1237The text was updated successfully, but these errors were encountered: