Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen "MetricProducer MUST accept configuration for the Resource" requirement #3615

Closed
aabmass opened this issue Jul 20, 2023 · 1 comment · Fixed by #3636
Closed

Loosen "MetricProducer MUST accept configuration for the Resource" requirement #3615

aabmass opened this issue Jul 20, 2023 · 1 comment · Fixed by #3636
Labels
spec:metrics Related to the specification/metrics directory

Comments

@aabmass
Copy link
Member

aabmass commented Jul 20, 2023

Initially discussed in #3601 (comment). The spec currently says

opentelemetry-specification/specification/metrics/sdk.md

Lines 1398 to 1400 in 8ae0f6f

If the batch of [Metric points](./data-model.md#metric-points) returned by
`Produce()` includes a [Resource](../resource/sdk.md), the `MetricProducer` MUST
accept configuration for the [Resource](../resource/sdk.md).

Since SDK's may throw away the Resource returned by a MetricProducer, we can loosen this requirement to a SHOULD or MAY

Part of #3599 @dashpole
@aabmass aabmass added the spec:metrics Related to the specification/metrics directory label Jul 20, 2023
@aabmass
Copy link
Member Author

aabmass commented Jul 20, 2023

I can send a PR for this if someone assigns me

@MrAlias MrAlias assigned aabmass and unassigned jmacd Jul 26, 2023
@dashpole dashpole mentioned this issue Aug 1, 2023
Merged
@dashpole dashpole moved this from Todo to In Progress in Go: Metric SDK (GA) Aug 1, 2023
@aabmass aabmass removed their assignment Aug 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Metric SDK (GA) Aug 10, 2023
@dashpole dashpole mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec:metrics Related to the specification/metrics directory
Projects
No open projects
Go: Metric SDK (GA)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MetricProducer.Produce can include a Resource parameter dashpole/opentelemetry-specification
2 participants
@aabmass @jmacd