-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize environment variables between SDK implementations #572
Comments
Just to update everybody on the Python side: The Python implementation currently reads any environment variable prefixed with The API currently uses |
Erlang is also using |
FYI re: |
related PR: open-telemetry/opentelemetry-js#924 worth noting: in code configuration of the exporter's host value is more authoritative than the env var. Not sure if this is what we want for all env vars or not. We would probably want consistent authority (in code > env var or vice-versa) across env vars. |
If I recall correctly, we didn't want to name things "OTEL" because there was already another technical concept that was called that. That said, a google search for "otel" pops up nothing, so maybe it's ok? |
Java uses the following environment variables:
|
@mwear do you have enough information to pick up a proposal? We are rapidly adding functionality to Python's auto-instrumentation which heavily utilizes environment variables. |
@toumorokoshi I'll draft up a specification this week. The goal will be to capture the environment variables that make sense to be standardized between languages. For language specific environment variables, it might be a good idea of us to decide on conventions each language can use, rather than specific environment variable names. We can have that conversation as part of this spec as well. |
In no way tied to these 😄, just reporting the current state for Java auto-instrumentation. Looking forward to using the standardized env vars.
|
Oh, also:
|
+1 to standardize the namespacing for language-specific environment variables. |
@naseemkullah No, I believe that rate and probability are inverses of each other. I believe the reason we use "rate" to describe inverse probability is that if you see one sampled item using probability |
🤯 Thanks @jmacd , while I don't quite get why probability and rate are inverses of each other, I am leaning more towards |
rate and probability are not actually inverses of each other. rate describes a ratio between an independent and a dependent variable, while probability is the chance of some occurrence. You could technically say "sample at a rate of 0.1 sampled traces per trace" (sampled traces dependent on total traces) and that would seem to equal a 10% probability. But, if you sampled every 10th trace, that would still be a 1 in 10 rate. In that scenario, each trace would not have a 10% probability of being sampled. |
Currently environment variables are being defined individually by SIGs on a one off basis. We should coordinate this effort and come up with a list of standardized environment variable names, values, and behavior.
As a starting point, we should document the environment variables that already exist, and move on to additional definitions from there.
Here are some environment variable definitions that have been discussed in spec issues. If SIGs can add environment variables that they are using, or would like to define in the comments, I can update this list.
Another important consideration we need to address, is the value format. Here is a related issue: #505.
The text was updated successfully, but these errors were encountered: