Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate OTEP-83 (Introducing InstrumentationLibrary) into spec #809

Open
iNikem opened this issue Aug 14, 2020 · 9 comments
Open

Integrate OTEP-83 (Introducing InstrumentationLibrary) into spec #809

iNikem opened this issue Aug 14, 2020 · 9 comments
Assignees
Labels
area:sdk Related to the SDK priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory

Comments

@iNikem
Copy link
Contributor

iNikem commented Aug 14, 2020

There is no definition nor description of InstrumentationLibrary in the spec right now. OTEP-83 which introduced the InstrumentationLibrary message was not integrated into spec.

@iNikem iNikem added the spec:trace Related to the specification/trace directory label Aug 14, 2020
@tigrannajaryan
Copy link
Member

@Oberon00 Oberon00 changed the title Integrate OTEP-83 into spec Integrate OTEP-83 (Introducing InstrumentationLibrary) into spec Aug 18, 2020
@andrewhsu
Copy link
Member

from the spec issue triage mtg today, looks like PR #800 closes this issue

@arminru
Copy link
Member

arminru commented Aug 24, 2020

@andrewhsu #800 solely defined the Zipkin tags for specifying the instrumentation library when exporting to Zipkin but is otherwise unrelated to this issue. This issue is asking for some prose describing what the instrumentation library defined in OTEP 83 is to be added right into the spec.

@arminru arminru reopened this Aug 24, 2020
@arminru
Copy link
Member

arminru commented Aug 24, 2020

@iNikem Is the description in the glossary mentioned above and the overview referenced there (https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/overview.md#instrumentation-libraries) sufficient or would you expect more details or better cross-references?

@iNikem
Copy link
Contributor Author

iNikem commented Aug 24, 2020

This issue was requested by @SergeyKanzhelev in #800 (comment). Please ask him for more clarifications :)

@arminru arminru added area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory labels Aug 24, 2020
@SergeyKanzhelev
Copy link
Member

@iNikem @arminru I'd suggest to outline the required fields of the InstrumentationLibrary structure. Otherwise the conversion document we have in Zipkin and Jaeger exporter documents are referring to the name and version that was never defined as required.

Moving nice pseudo-graphics explaining the concept in more details may be a bonus.

@arminru
Copy link
Member

arminru commented Aug 25, 2020

@Oberon00
Copy link
Member

I think this is a specific instance of #158.

@Oberon00 Oberon00 added area:sdk Related to the SDK and removed area:api Cross language API specification issue labels Aug 25, 2020
@andrewhsu andrewhsu added release:after-ga Not required before GA release, and not going to work on before GA priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA and removed release:after-ga Not required before GA release, and not going to work on before GA labels Aug 28, 2020
@andrewhsu
Copy link
Member

talked about this at the spec issue triage today, marking as required for ga p3, but doesn't seem like this is big blocker for ga, can bump down to release-after-ga if needed later

@bogdandrutu bogdandrutu added release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs and removed release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

7 participants