From 534563102d91638eb3334b345578d719d64c12ed Mon Sep 17 00:00:00 2001 From: Bogdan Drutu Date: Tue, 9 Feb 2021 19:17:42 -0800 Subject: [PATCH] Update default for span limits to 128, 1000 seems off Signed-off-by: Bogdan Drutu --- CHANGELOG.md | 1 + specification/sdk-environment-variables.md | 6 +++--- specification/trace/sdk.md | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f5f81d853a..1e0d7edbe15 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ New: Updates: +- Update default limit for span attributes, events, links to 128([#1419](https://github.com/open-telemetry/opentelemetry-specification/pull/1419)) - Update OT Trace propagator environment variable to match latest name([#1406](https://github.com/open-telemetry/opentelemetry-specification/pull/1406)) - Remove Metrics SDK specification to avoid confusion, clarify that Metrics API specification is not recommended for client implementation diff --git a/specification/sdk-environment-variables.md b/specification/sdk-environment-variables.md index 5cbe2a7bf6a..23112ea5d15 100644 --- a/specification/sdk-environment-variables.md +++ b/specification/sdk-environment-variables.md @@ -77,9 +77,9 @@ Depending on the value of `OTEL_TRACES_SAMPLER`, `OTEL_TRACES_SAMPLER_ARG` may b | Name | Description | Default | Notes | | ------------------------------- | ------------------------------------ | ------- | ----- | -| OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | Maximum allowed span attribute count | 1000 | | -| OTEL_SPAN_EVENT_COUNT_LIMIT | Maximum allowed span event count | 1000 | | -| OTEL_SPAN_LINK_COUNT_LIMIT | Maximum allowed span link count | 1000 | | +| OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | Maximum allowed span attribute count | 128 | | +| OTEL_SPAN_EVENT_COUNT_LIMIT | Maximum allowed span event count | 128 | | +| OTEL_SPAN_LINK_COUNT_LIMIT | Maximum allowed span link count | 128 | | ## OTLP Exporter diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 0e37d6328cc..89da29878d7 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -300,7 +300,7 @@ resulting in crashes that are difficult to recover from safely. To protect against such errors, SDK Spans MAY discard attributes, links, and events that would increase the number of elements of each collection beyond -the recommended limit of 1000 elements. SDKs MAY provide a way to change this limit. +the recommended limit of 128 elements. SDKs MAY provide a way to change this limit. If there is a configurable limit, the SDK SHOULD honor the environment variables specified in [SDK environment variables](../sdk-environment-variables.md#span-collection-limits).