Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CHANGELOG from specification over, keeping only SEMCONV sections. #14

Closed
jsuereth opened this issue May 12, 2023 · 3 comments · Fixed by #139
Closed

Migrate CHANGELOG from specification over, keeping only SEMCONV sections. #14

jsuereth opened this issue May 12, 2023 · 3 comments · Fixed by #139
Assignees

Comments

@jsuereth
Copy link
Contributor

No description provided.

@reyang
Copy link
Member

reyang commented May 15, 2023

This is partially resolved by #18 (do we need historical changes or we can point to the spec repo?).

@reyang reyang closed this as completed May 15, 2023
@reyang reyang reopened this May 15, 2023
@arminru
Copy link
Member

arminru commented May 15, 2023

@reyang I think either is fine. It would be a one-time effort to copy them over and would provide a nicer experience (one can ctrl+f in this one single file) but adding a line saying the following should also be enough:

Previously, the semantic conventions in this repository were part of open-telemetry/opentelemetry-specification, for which the changelog can be found here.

@jsuereth
Copy link
Contributor Author

jsuereth commented May 16, 2023

Our automation for schema_url basically requires historical changes. Effectively it uses version numbers in CHANGELOG.md to verify schema_url accounts for all of them.

See: https://github.com/open-telemetry/semantic-conventions/blob/main/internal/tools/schema_check.sh#L18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants