Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move metric definitions to YAML - RPC metrics #74

Closed
1 of 2 tasks
joaopgrassi opened this issue Jun 1, 2023 · 1 comment
Closed
1 of 2 tasks

Move metric definitions to YAML - RPC metrics #74

joaopgrassi opened this issue Jun 1, 2023 · 1 comment
Labels
area:rpc

Comments

@joaopgrassi
Copy link
Member

joaopgrassi commented Jun 1, 2023 •
edited
Loading

Move the metric definitions text from rpc-metrics.md to a respective rpc-metrics.yaml and re-generate the markdown tables.

This work includes the following tasks:

  • Port metrics to YAML and re-generate the markdown (keep as much as status quo as possible)
  • Modify the markdown file to add all attributes to all metrics, instead of relying on the "static" table at the end of the document. See discussion Generate RPC metrics from YAML #93 (comment)
@joaopgrassi joaopgrassi mentioned this issue Jun 7, 2023
Merged
@jsuereth jsuereth mentioned this issue Jun 26, 2023
Closed
@github-actions github-actions bot added the Stale label Feb 18, 2024
@joaopgrassi joaopgrassi removed the Stale label Feb 26, 2024
@joaopgrassi
Copy link
Member Author

This is already done: Metrics are in yaml and generated by Weaver https://github.com/open-telemetry/semantic-conventions/blob/main/model/rpc/metrics.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rpc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaopgrassi @arminru