Add k8s.volume.{name,type} attributes #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
add_k8s_volume_type
branch
6 times, most recently
from
c27b687 to
d147900
Compare
jsuereth
requested changes
Jul 18, 2024
ChrsMark
force-pushed
the
add_k8s_volume_type
branch
from
9ac2bab to
9f93b42
Compare
|
@open-telemetry/semconv-k8s-approvers could you take a look? |
TylerHelmuth
approved these changes
Aug 2, 2024
lmolkova
reviewed
Aug 2, 2024
ChrsMark
force-pushed
the
add_k8s_volume_type
branch
from
b83bfbe to
15e3207
Compare
|
Thank's @lmolkova for the comments! Should be addressed now. |
lmolkova
approved these changes
Aug 5, 2024
|
Hey @jsuereth, could you take another look please? |
jsuereth
approved these changes
Aug 13, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
add_k8s_volume_type
branch
from
62bbbf4 to
013e448
Compare
|
The failure is unrelated. I have filed #1332 to fix this. |
ezimuel
pushed a commit
to ezimuel/semantic-conventions
that referenced
this pull request
Aug 20, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Add k8s.volume.{name,type} attributes.
From https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.102.0/receiver/kubeletstatsreceiver/internal/kubelet/conventions.go#L7
Merge requirement checklist
[chore]