Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weaver registry generate ignores --templates argument #78

Closed
jsuereth opened this issue Apr 2, 2024 · 0 comments · Fixed by #136
Closed

weaver registry generate ignores --templates argument #78

jsuereth opened this issue Apr 2, 2024 · 0 comments · Fixed by #136
Labels
help wanted Extra attention is needed

Comments

@jsuereth
Copy link
Contributor

jsuereth commented Apr 2, 2024

If you pass --templates to weaver registry generate the argument is ignored. This is because the default GeneratorConfig is used here: https://github.com/open-telemetry/weaver/blob/main/src/registry/generate.rs#L77

Simple fix - taking note while working on demo for semconv repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
2 participants