Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FOP 1.1 [sf#108] #108

Closed
tomschr opened this issue Mar 3, 2015 · 9 comments
Closed

Support FOP 1.1 [sf#108] #108

tomschr opened this issue Mar 3, 2015 · 9 comments

Comments

@tomschr
Copy link
Collaborator

tomschr commented Mar 3, 2015

Reported by tom_schr on 2012-10-26 17:49 UTC
This ticket is just for collecting some information about FOP 1.1 and its features. I think, it is worth implementing it in DAPS.

  • Disabeling Complex Scripts with -nocs
    Complex scripts are a new feature of FOP 1.1. However, as we don't create manuals with BIDI and complex script support needs a lot of memory, I think we can savely disable that feature. Use the -nocs option on the command line.
  • Support PDF Images
    It seems, we cannot use PDF graphics with FOP directly. We need a special JAR file which supports PDF Images. Either we fix our daps-fop script and add the JAR to the ADDITIONAL_JARS environment variable, or we add it to the xmlgraphics-fop package. See separate Ticket [Customize DocBook5 to Create Novdoc5 [sf#180] #179].
  • Use FOP Extensions
    FOP 1.1 supports some nice FO extensions like PDF bookmarks, fox:external-document, prepress support and more.
    Probably, these features are better supported upstream. I add them here so we don't forget it.
    See also discussion:
    ** Add support for fox:font-feature-settings
    ** Add support for fox:complex-scripts property, applicable to block level FOs
  • Support (more?) Metadata
    We should investigate, if we could transform more metadata from our DocBook sources into our FO.

@frank: Probably, the first feature is only interesting for you. After you have implemented it, assign it back to me, please. :-)

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Commented by randombauer on 2012-12-06 14:48
PDF Image support doesn't work with the JAR-file, it produces exception errors or PDFs with no images.
Next test steps:

  • check the PDF Image-support JAR implementation for errors (maybe something is missing)
  • try the newest xmlgraphics-fop-commons (which might have PDF image support integrated)
  • look for a different pdf image support JAR
  • use eps instead of pdf

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Commented by randombauer on 2012-12-12 10:01
PDF Image support works now:

  1. Download the JARs from the source above
  2. Move 'fop-pdf-images.jar pdfbox.jar jempbox.jar fontbox.jar' to /usr/share/java/
  3. Add the JAR names to the 'BASE_JARS' in the fop-script at /usr/bin/fop and to the 'ADDITIONAL_JARS' in daps-fop at daps/libexec/daps-fop

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Updated by fsundermeyer on 2013-01-15 14:24

  • milestone: 1.x --> 2.0

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Updated by fsundermeyer on 2013-04-11 21:34

  • assigned_to: Frank Sundermeyer --> Thomas Schraitle

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Commented by fsundermeyer on 2013-04-11 21:34
Added the -nocs option for fop >= 1.1 to libexec/daps-fop with SVN commit [r2933].
Reassingning.

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Commented by tom_schr on 2013-07-01 07:56
Unfortunately, it seems it is not that easy.

The -nocs option is language dependant. Complex scripting is needed for Arabic and CJK, but not Latin.

How could we do that? Could we use the DC files for that? Or should DAPS do it automatically?

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Commented by fsundermeyer on 2014-10-23 13:27
I vote for not disabling complex scripts - I wasn't able to see any differences between a "fop" and a "fop -nocs" run on my test machine. memory consumption was not higher without -nocs.

@ghost
Copy link

ghost commented Oct 29, 2015

@tomschr Is this fixed? I think we have all been using FOP 1.1 for some time now.

Of the original items this bug was opened for, I see discussion on 2 of 3:

  • Disable Complex Scripts with -nocs = off the table
  • Support PDF Images = done
  • Use FOP Extensions = no discussion, though this is probably a stylesheet topic.

@ghost ghost added topic-pdf and removed fo labels Oct 30, 2015
ghost pushed a commit that referenced this issue Nov 2, 2015
Toms comment from March 3 indicates that -nocs does not pose a memory
problem, so it should not hurt us either:
  #108 (comment)

Unfortunately, even with this applied, Arabic does not work
tomschr added a commit that referenced this issue Dec 2, 2015
* Bugfixes:
  - Target text shows remarks (issue #293)
  - DAPS checklink doesn't work (issue #296)
  - ASPELL_EXTRA_DICT from ~/.config/daps/dapsrc is ignored (issue #297)
  - DAPS package includes SUSE wordlist (issue #298)
  - Parameter passed with --param is ignored with subcommand "text" (issue #299)
  - Target locdrop does not generate graphics-setfiles-$(DOCNAME)$(LANGSTRING).tar.bz2
    (issue #302)
  - Translation check for locdrop (issue #306)
  - Add --optipng to unpack-locdrop (issue #307)
  - Add --xmlonly / --imgonly switches to list-srcfiles (issue #310)
  - bigfile creates unresolved xrefs for DocBook5 (issue #314)
  - Improve DocBook5 -> DocBook4 -> Novdoc Stylesheets (issue #311)
  - Enhancements in user guide, thanks to Martin Koeditz (issue #315)
  - FO contains wrong image paths when XML contains no profiling PI (issue #316)
  - DB-4-to-5 migration: missing book titles/productnames/productnumbers
    (issue #319)

* New Features:
  - Option --schema lets you specify an URN to a DocBook 5 schema that is to
    be used for validation. Will be ignored when validating Docbbok4 documents.
  - DOCBOOK5_STYLE_URI, DOCBOOK5_STYLE_URI, and DOCBOOK4_STYLE_URI may now
    also point to a local file. If the URN begins with the prefix "file://",
    it will not be resolved via xmlcatalog, but rather taken as is (minus
    "file://").
  - Add conversion options to online-docs:
    . --db5todb4: converts DocBook 5 sources to a DocBook 4 bigfile
    . --db5todb4nh: converts DocBook 5 sources to a DocBook 4 bigfile without
      a DOCTYPE declaration
    . --dbtonovdoc: converts DocBook 4/5 to Novdoc

* Misc:
  - Do not set -nocs, hurts us when building Arabic (related: issue #108)
  - Avoid adding version attribute on all elements (commit 3a273d5)
@fsundermeyer
Copy link
Member

Looks like this can be closed....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants