Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XIncludes with parse=text [sf#71] #71

Closed
tomschr opened this issue Mar 3, 2015 · 9 comments
Closed

Support XIncludes with parse=text [sf#71] #71

tomschr opened this issue Mar 3, 2015 · 9 comments

Comments

@tomschr
Copy link
Collaborator

tomschr commented Mar 3, 2015

Reported by taroth21 on 2012-04-23 15:18 UTC
Usage example: For automatically including a text config file in a book:

<appendix>
  <title>&daps; Configuration File</title>
   <screen><xi:include xmlns:xi="http://www.w3.org/2001/XInclude"
     href="../../etc/config"
     parse="text">
        <xi:fallback>
         <xi:include xmlns:xi="http://www.w3.org/2001/XInclude"
         href="/etc/daps/config"
         parse="text"/>
        </xi:fallback>
    </xi:include>
  </screen>
 </appendix>

From an XML point of view, this already works with DocBook, but currently, DAPS does not support it.

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Updated by fsundermeyer on 2012-07-06 14:27

  • assigned_to: Frank Sundermeyer --> Thomas Schraitle

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Commented by fsundermeyer on 2012-07-06 14:27
This feature is a bit problematic when it comes to profiling and distributing sources:

Profiling:
The profiled files are written to a directory that not necessarily resides on the same level as the original directory, so relative paths will most probably not work after profiling.

Distributing:
When creating source archives (e.g. results from targets like locdrop or package-source), the text file includes are not part of the archive, because DAPS ATM has no means to find out which additional files need to be packed.

The following would be needed for a proper implementation:

  • adding these text-file includes to filelists (requires separate handling and a new stylesheets)
  • copying the test files into the profiling directory
  • rewriting the links to the text files (so they point tothe copied ones) in the profiled sources

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Updated by tom_schr on 2012-08-07 11:58

  • labels: --> xslt

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Updated by tom_schr on 2012-12-07 07:32

  • priority: high --> low

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Updated by tom_schr on 2013-01-15 14:20

  • status: open --> wont-fix

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Commented by tom_schr on 2013-01-15 14:20
This feature is currently not possible with profiling and XInclude parse=text. The stylesheets cannot find the filenames. This is very unfortunate, but there is no solution at the moment.

@tomschr
Copy link
Collaborator Author

tomschr commented Jun 29, 2015

Seems we have a new idea...

@tomschr tomschr reopened this Jun 29, 2015
@tomschr tomschr added this to the 2.1 milestone Jun 29, 2015
tomschr added a commit that referenced this issue Jun 29, 2015
tomschr added a commit that referenced this issue Jun 29, 2015
* Parameter: xml.or.images -> filetype

* Separated filenames which are XML (without parse or parse="xml")
  or text (parse="text") for xi:include elements
@tomschr
Copy link
Collaborator Author

tomschr commented Jun 29, 2015

@taroth21 When the feature is ready, could you test it please?

@fsundermeyer
Copy link
Member

Finally implemented with commit 22c7c3a

fsundermeyer added a commit that referenced this issue Jul 2, 2015
Stable release DAPS 2.1:

- added support for webhelp
- added support for <xi:include ... parse="text"> (issue #71)
- handling of passing XSLT parameters on the command line has been
  improved (issue #263)
- improved handling of doxcuments that do not need to be profiled
- daps_autobuild: changed the order of builds to increase performance
- Bugfix package-src: removed extraneous text
- Bugfix daps_autobuild: in case no rebuild was necessary, rsync
                         deleted the previous results
- Bugfix DB4 -> DB5 migration: Fixed various issues in the migration
                               stylesheet
fsundermeyer added a commit that referenced this issue Jul 2, 2015
Stable release DAPS 2.1:
- added support for webhelp
- added support for <xi:include ... parse="text"> (issue #71)
- handling of passing XSLT parameters on the command line has been
  improved (issue #263)
- improved handling of doxcuments that do not need to be profiled
- daps_autobuild: changed the order of builds to increase performance
- Bugfix package-src: removed extraneous text
- Bugfix daps_autobuild: in case no rebuild was necessary, rsync
                         deleted the previous results
- Bugfix DB4 -> DB5 migration: Fixed various issues in the migration
                               stylesheet
@ghost ghost removed the in progress label Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants