Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for DITAA 'images' #541

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Added support for DITAA 'images' #541

merged 2 commits into from
Feb 12, 2020

Conversation

fsundermeyer
Copy link
Member

@fsundermeyer fsundermeyer commented Feb 11, 2020 •
edited
Loading

Added DITAA support. Please test.

Images go to `images/src/ditaa/*.ditaa

IN XML, link to them as .png

ATM only supports .png conversion, since ditaa 0.11 which adds svg support is not yet packaged for openSUSE.

Will fix #540

@fsundermeyer fsundermeyer requested review from tbazant and a user February 11, 2020 16:08
tbazant
tbazant approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@tbazant tbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image in the generated PDF is a bit blurred, but generally it works well.

@fsundermeyer fsundermeyer merged commit 64fff90 into develop Feb 12, 2020
@fsundermeyer fsundermeyer deleted the add_ditaa_support branch February 12, 2020 13:49
ghost
ghost reviewed Feb 12, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You merged ... but anyway, I'd suggest the following two parameters to ditaa:
--scale 2.5 --no-shadows

  • --scale to avoid blurriness
  • --no-shadows because those shadows look a bit 90s

make/images.mk
@@ -45,6 +47,11 @@
# SVG | PNG | SVG,PDF
#........|...........|..........
#
# NOTE on DITAA:
# Version 0.10 that is packaged for openSUSE does not support SVG output
# upstream 0.11 has SVG support (--svg)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbazant tbazant tbazant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for DITAA images
2 participants
@fsundermeyer @tbazant