fix: Reset TTY on exit #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exiting the test suite with Ctrl+C during harvesting previously broke the terminal due to multibar not being allowed to cleanup. This fix ensures that the terminal is properly reset.
This also fixes an issue where the microservice Node.js process was orphaned if the test suite was terminated during authentication, as Puppeteer was not being allowed to shutdown properly.
Previously all three processes were being terminated at the same time, which led to inconsistent behaviour that was difficult to debug and reason about. A clean exit is now achieved as follows: