New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update command that use subprocess #57

Closed

pradal opened this issue May 13, 2024 · 1 comment · Fixed by #58

Assignees

Contributor

pradal commented May 13, 2024

command.py that runs scons and cmake, use a deprecated function of subprocess : call.
This is deprecated and we need to move to subprocess.run

pradal assigned pradal and pellem

Contributor Author

pradal commented May 13, 2024

We suspect that caribu CI fails due to a wait that is not respected.
See https://docs.python.org/3/library/subprocess.html#subprocess.call

pradal mentioned this issue

Update scons command with new run rather tha deprecated call subprocess. #58

Merged

pradal closed this as completed in #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment