Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure on armhf - integer overflow #2846

Closed
lucaskanashiro opened this issue Mar 10, 2021 · 3 comments
Closed

Test failure on armhf - integer overflow #2846

lucaskanashiro opened this issue Mar 10, 2021 · 3 comments

Comments

@lucaskanashiro
Copy link

I am trying to update the runc Ubuntu package to version 1.0-rc93 but the following test is failing on armhf (32 bits):

# github.com/opencontainers/runc/libcontainer/seccomp/patchbpf [github.com/opencontainers/runc/libcontainer/seccomp/patchbpf.test]
src/github.com/opencontainers/runc/libcontainer/seccomp/patchbpf/enosys_linux_test.go:180:20: constant 3735928559 overflows int
src/github.com/opencontainers/runc/libcontainer/seccomp/patchbpf/enosys_linux_test.go:204:19: constant 3735928559 overflows int
src/github.com/opencontainers/runc/libcontainer/seccomp/patchbpf/enosys_linux_test.go:227:25: constant 3735928559 overflows int
FAIL	github.com/opencontainers/runc/libcontainer/seccomp/patchbpf [build failed]

The new "special handling for seccomp profiles to avoid making new syscalls unusable for glibc" is exactly the feature that I am looking for, but this failure is a blocker. Full build log:

https://launchpadlibrarian.net/527223578/buildlog_ubuntu-hirsute-armhf.runc_1.0.0~rc93-0ubuntu1~ppa1_BUILDING.txt.gz

@tianon
Copy link
Member

tianon commented Mar 12, 2021

I think this was fixed in #2768 (which isn't in the latest release yet). 😅

@kolyshkin
Copy link
Contributor

@lucaskanashiro please test the git tip (or grab the first commit from #2768) and report whether it fixes your issue.

If yes, guess we can close it as a duplicate fo #2783.

@lucaskanashiro
Copy link
Author

Ah I did not notice this fix, my bad. It indeed fixes my issue! Sorry for the noise, we can close this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants