Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define documented const for magic -1 file-descriptor #3934

Closed
thaJeztah opened this issue Jul 11, 2023 · 2 comments
Closed

Define documented const for magic -1 file-descriptor #3934

thaJeztah opened this issue Jul 11, 2023 · 2 comments

Comments

@thaJeztah
Copy link
Member

The -1 to a var can work (although unsure which would be a good var name :-D). But yes, it touches way other func than this PR, so I agree it should be in another PR. I'm on the fence if just keeping -1 is okay, though, it is pretty widely used...

relates to #3717 (comment)_
@thaJeztah thaJeztah mentioned this issue Jul 11, 2023
Merged
5 tasks
@rata
Copy link
Member

rata commented Jul 21, 2023

@thaJeztah I think we can close this now that #3939 is merged. Can you close (I can't, sorry :))

@kolyshkin
Copy link
Contributor

Yes, we no longer use -1 in that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rata @thaJeztah @kolyshkin