Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema definitions of 'int64' and 'uint64' types have ranges not representable in 64 bits #1051

Closed
johnbartholomew opened this issue Jun 23, 2020 · 2 comments · Fixed by #1060

Comments

@johnbartholomew
Copy link
Contributor

In schema/defs.json, there are definitions for 'int64' and 'uint64' types:

        "int64": {
            "type": "integer",
            "minimum": -9223372036854776000,
            "maximum": 9223372036854776000
        },
        "uint64": {
            "type": "integer",
            "minimum": 0,
            "maximum": 18446744073709552000
        },

These minimum and maximum values are not representable in a normal signed/unsigned 64-bit integer. Is there a reason that these definitions don't match normal INT64_MIN/INT64_MAX/UINT64_MAX values? The other sized integer type definitions in the schema have the min/max values I would expect.

@thaJeztah
Copy link
Member

I see it was added in #313, and see no mention of a specific reason, so this may be an oversight, but pinging @vbatts @mrunalp in case there's some odd reason I'm overlooking.

@thaJeztah
Copy link
Member

Discussed with some people, and this was likely an oversight; @johnbartholomew are you interested in contributing a pull request to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants