Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make container id a required parameter for all runc(client) operations #315

Closed
mikebrow opened this issue Jan 21, 2016 · 3 comments
Closed

Comments

@mikebrow
Copy link
Member

Per the face to face discussions we decided to make --id, or similar parameter, required for all of the runc operations.

I'll generate a PR to update the runtime.md docs to specify the need for the container id for each of the runc operations. In particular, update the lifecyle description.

@wking
Copy link
Contributor

wking commented Jan 21, 2016

On Thu, Jan 21, 2016 at 03:49:15PM -0800, Mike Brown wrote:

I'll generate a PR to update the runtimemd docs to specify the need
for the container id for each of the runc operations In particular,
update the lifecyle description

It's not my favorite approach [1,2,3], but as of 6f2665a it looks like
this is already done in #225.

 Subject: Re: removal of /run/opencontainer/containers, add --state?
 Date: Tue, 8 Dec 2015 15:49:57 -0800
 Message-ID: <20151208234957.GK2767@odin.tremily.us>

@mikebrow
Copy link
Member Author

Ah I see.. been ill for a bit just getting back into it. Thx Trevor will close.

@duglin
Copy link
Contributor

duglin commented Jan 22, 2016

I think a PR for runc is still needed though and we should just make it a normal arg, not a flag.
ie. runc <action> <id> ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants