Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference spec when reporting violations #16

Closed
wking opened this issue Jan 25, 2016 · 4 comments
Closed

Reference spec when reporting violations #16

wking opened this issue Jan 25, 2016 · 4 comments

Comments

@wking
Copy link
Contributor

wking commented Jan 25, 2016

Validators (e.g. the Nu Html Checker) often report errors with references to the specification requirement that was violated. To get a good user experience and protect against checking unspecified behavior, I think ocitools checks should be setup to link to the relevant spec wording for any check they perform. For example, a bundle with non-UTF-8 JSON would fail with a reference to this. If this sounds like a reasonable policy, we should write it up in the README or a CONTRIBUTING.md and open issues/PRs for adjusting any existing checks.

@mrunalp
Copy link
Contributor

mrunalp commented Jan 25, 2016

@wking This is a good idea but maybe hard to maintain the links all the time. How about we target this for 1.0?

@wking
Copy link
Contributor Author

wking commented Jan 25, 2016

On Mon, Jan 25, 2016 at 10:19:31AM -0800, Mrunal Patel wrote:

@wking This is a good idea but maybe hard to maintain the links all
the time. How about we target this for 1.0?

There aren't that many releases left between now and 1.0, so I'd just
start now. If we link to a particular version of the spec, it will
(a) help with stability and (b) mark stale checks that should be
audited updated after each spec release.

@wking wking changed the title References spec when reporting volations Reference spec when reporting volations Jan 25, 2016
@wking wking changed the title Reference spec when reporting volations Reference spec when reporting violations Jan 25, 2016
@wking
Copy link
Contributor Author

wking commented Jun 13, 2016

On Mon, Jan 25, 2016 at 10:19:31AM -0800, Mrunal Patel wrote:

@wking This is a good idea but maybe hard to maintain the links all
the time. How about we target this for 1.0?

We're into 1.0.0-rc1, so I'd guess it's time to do this? I can start
filing PRs if we want to green-light the general idea.

@wking
Copy link
Contributor Author

wking commented Jul 28, 2017

With #354 merged yesterday, we now have a way to do this. We still need to transition a lot of code to the new error model, but it's no longer blocking on designing the approach.

@wking wking closed this as completed Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants