-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need a release so default golang tooling will work #327
Comments
I want to get #324 fixed for a variety of different reasons (it's only blocked because it turns out that Go's |
I think the issue is not a matter of having or not having a release, but instead that existing projects which use Instead, what I propose we do is make a copy of the //#warning This module has been moved to <github.com/opencontainers/umoci>. \
// Please update your import paths, as <github.com/openSUSE/umoci> will \
// not receive any further updates.
import "C" As well as a note in the README explaining the situation, and archive the entire project. Annoyingly this is the only way to insert build warnings into Go programs, but it should hopefully work everywhere. However if we're going to go through all of this pain anyway, maybe we should consider using vanity imports ( <meta name="go-import" content="umo.ci git github.com/opencontainers/umoci">
<meta name="go-source" content="umo.ci https://github.com/opencontainers/umoci https://github.com/opencontainers/umoci/tree/master{/dir} https://github.com/opencontainers/umoci/blob/master{/dir}/{file}#L{line}"> But I'd like to know what you both (@tych0 and @vbatts) think about vanity URLs or if we should just use |
Exactly. I don't think this a particularly big deal, since as far as I'm aware, there is only one downstream project, and I already fixed it :). I'd say save yourself the pain and just tag a new release. |
We can tag a new release, but if people are going to get compilation errors anyway we might as well make them explain what they should do. |
I've set up https://github.com/openSUSE/umoci to have a dummy release of |
Right now we get failing builds: https://travis-ci.org/github/anuvu/stacker/jobs/699350166
And when I replace things globally, I get:
I can use replace to work around this for now, but we should probably do a release to fix this behavior.
The text was updated successfully, but these errors were encountered: