Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after use curvebs for the backend of curvefs,a unified name needed #2514

Closed
wuhongsong opened this issue Jun 6, 2023 · 5 comments
Closed
Assignees
Labels
assigned enhancement improve feature good first issue Good for newcomers

Comments

@wuhongsong
Copy link
Contributor

wuhongsong commented Jun 6, 2023

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

Regardless of whether the backend is s3, or bs, we now use a unified cache layer(https://github.com/opencurve/curve/tree/fs_curvebs_storage_support) ,so we need a unified name,

for example: S3ChunkInfo maybe replaced by ChunkInfo(or other name)

Describe the solution you'd like (描述你期望的解决方法)

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@wuhongsong wuhongsong added the enhancement improve feature label Jun 6, 2023
@wuhongsong wuhongsong changed the title A unified name needed after use curvebs after use curvebs for the backend of curvefs,a unified name needed Jun 6, 2023
@wuhongsong wuhongsong added the good first issue Good for newcomers label Jun 6, 2023
@infdahai
Copy link

infdahai commented Jun 6, 2023

Let me have a try.

@wuhongsong
Copy link
Contributor Author

Let me have a try.

yeap, lets do it.

@Cyber-SiKu
Copy link
Contributor

@infdahai Have you encountered any difficulties?

@infdahai
Copy link

@Cyber-SiKu I will propose a draft pr in these few days.

@caoxianfei1
Copy link
Contributor

@Cyber-SiKu I will propose a draft pr in these few days.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned enhancement improve feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants