Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing kestrel-lang requires stix-shifter, docker, etc. #118

Closed
pcoccoli opened this issue Sep 14, 2021 · 5 comments
Closed

Installing kestrel-lang requires stix-shifter, docker, etc. #118

pcoccoli opened this issue Sep 14, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@pcoccoli
Copy link
Collaborator

kestrel_datasource_stixbundle and kestrel_analytics_docker are "built-ins" but some kestrel installations may not use them. Since the datasource and analytics interfaces are modular, we should not build these in as it makes container installations larger than they need to be.

@pcoccoli pcoccoli added the enhancement New feature or request label Sep 14, 2021
@subbyte
Copy link
Member

subbyte commented Sep 14, 2021

pip supports extras_require in setup.cfg, and we will find if we can do something like not use some dependencies when doing pip install.

Reference:

@subbyte
Copy link
Member

subbyte commented Jul 25, 2023

Two main options

  1. optional dep (dash or underscore is currently an issue: Dependency resolution conflicts with hyphen in extras pypa/pip#11649)
pip install kestrel-lang[stix-shifter, docker, jupyter]
  1. separate packages
pip install kestrel-lang kestrel-datasource-interface-stixshifter kestrel-analytics-interface-docker kestrel-jupyter

2.b. separate packages + meta package

pip install kestrel-lang

which is

pip install kestrel-core kestrel-datasource-interface-stixshifter kestrel-analytics-interface-docker kestrel-jupyter

Problems to solve

Drawback of 1: how does kestrel_datasource_stixshifter package handles the case with no stix-shifter dep

Drawback of 2: how to do versioning of all packages

@pcoccoli
Copy link
Collaborator Author

I like the meta package idea. Though one thing to consider - if the vast majority of users will want to use Kestrel via Jupyter, then why not make the kestrel-jupyter package require everything (including stix-shifter)? Then the "easy" installation instructions are simply pip install kestrel-jupyter.

@subbyte
Copy link
Member

subbyte commented Oct 5, 2023

going to merge kestrel-jupyter into kestrel-lang using https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/

@subbyte
Copy link
Member

subbyte commented Oct 18, 2023

fixed in release 2023-10-18

@subbyte subbyte closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants