Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for PodDefault from Notebook Controller #61

Open
strangiato opened this issue Jan 26, 2023 · 1 comment · May be fixed by opendatahub-io/manifests#110
Open

Add Support for PodDefault from Notebook Controller #61

strangiato opened this issue Jan 26, 2023 · 1 comment · May be fixed by opendatahub-io/manifests#110
Labels
kind/enhancement New feature or request priority/normal An issue with the product; fix when possible

Comments

@strangiato
Copy link

Is your feature request related to a problem? Please describe.
There are often default options or configurations that we need to set for users Notebook pods such as environment variables, or configmaps/secrets that we want mounted to every users pod. There currently isn't a way to set any sort of global or default options for many of these settings.

Describe the solution you'd like
The upstream Kubeflow project supports an object called a PodDefault which can be used to configure different default options when starting a Notebook with Notebook Controller. This is a great replacement for what we used to be able to do with the SingleUserProfiles in JupyterHub.

Describe alternatives you've considered

Additional context
The kubeflow documentation shows an example of using PodDefaults in step 11 here:

https://www.kubeflow.org/docs/components/notebooks/quickstart-guide/

@strangiato strangiato added the kind/enhancement New feature or request label Jan 26, 2023
@LaVLaS
Copy link

LaVLaS commented Feb 13, 2023

@strangiato This sounds like a possible solution for opendatahub-io/odh-dashboard#824.

I am going to transfer this to our notebook-controller repo for triage

@LaVLaS LaVLaS transferred this issue from opendatahub-io/odh-manifests Feb 13, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning Apr 22, 2023
@harshad16 harshad16 added the priority/normal An issue with the product; fix when possible label Dec 7, 2023
harshad16 added a commit to harshad16/odh-kubeflow that referenced this issue Jun 14, 2024
[master] sync the master branch with upstream opendatahub stable branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request priority/normal An issue with the product; fix when possible
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants