Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Cluster Admin check doesn't get group rolebinding #464

Closed
1 task done
lucferbux opened this issue Aug 30, 2022 · 0 comments · Fixed by #465
Closed
1 task done

[Bug]: Cluster Admin check doesn't get group rolebinding #464

lucferbux opened this issue Aug 30, 2022 · 0 comments · Fixed by #465
Assignees
@lucferbux
Labels
feature/adminui Admin UI Feature infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Milestone
Release 2.1.1

Comments

@lucferbux
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Right now, the dashboard does not check whether a user is cluster-admin by being assigned to a Group with a cluster-admin rolebinding. It's just checking the rolebinding by user.

Expected Behavior

Dashboard should be checking all the groups a username is added and then the rolebindings of those groups.

Steps To Reproduce

  1. Create a new group
  2. Add a cluster-admin rolebinding
  3. Add a user to that group
  4. The user should have cluster-admin roles
  5. Log in to the dashboard
  6. The user does not have cluster-admin permission in the dashboard

Workaround (if any)

Add cluster-admin to the user instead to the group.

OpenShift Infrastructure Version

No response

Openshift Version

No response

What browsers are you seeing the problem on?

No response

Open Data Hub Version

No response

Relevant log output

No response
@lucferbux lucferbux added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet labels Aug 30, 2022
@lucferbux lucferbux mentioned this issue Aug 30, 2022
Merged
3 tasks
@andrewballantyne andrewballantyne added infrastructure Anything non feature/* related that improves general working of the Dashboard priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/adminui Admin UI Feature and removed untriaged Indicates the newly create issue has not been triaged yet labels Aug 30, 2022
@andrewballantyne andrewballantyne added this to the Release 2.2.0 milestone Aug 31, 2022
@andrewballantyne andrewballantyne mentioned this issue Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucferbux lucferbux

Labels
feature/adminui Admin UI Feature infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
Release 2.1.1
Development

Successfully merging a pull request may close this issue.

Add group check for cluster-admin lucferbux/odh-dashboard
2 participants
@andrewballantyne @lucferbux