From 2fb3ebceb1e3e504493ed8e01c74824364ccf398 Mon Sep 17 00:00:00 2001 From: Landon LaSmith Date: Fri, 2 Dec 2022 10:20:36 -0500 Subject: [PATCH] Add dashboard test for checking for CRD dependencies * Update the dashboard CI test for the new generic notebook name Signed-off-by: Landon LaSmith --- tests/Dockerfile | 2 +- tests/basictests/dashboard.sh | 7 ++++++- .../ods-ci/test-odh-dashboard-jupyterlab-notebook.robot | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/Dockerfile b/tests/Dockerfile index f73c30592..08cb83119 100644 --- a/tests/Dockerfile +++ b/tests/Dockerfile @@ -1,7 +1,7 @@ FROM quay.io/centos/centos:stream8 # List of chromedriver versions for download - https://chromedriver.chromium.org/downloads -ARG CHROMEDRIVER_VER=106.0.5249.21 +ARG CHROMEDRIVER_VER=108.0.5359.71 ARG ORG=opendatahub-io ARG BRANCH=master ARG ODS_CI_REPO=https://github.com/red-hat-data-services/ods-ci diff --git a/tests/basictests/dashboard.sh b/tests/basictests/dashboard.sh index dd76ae728..e97ba7507 100755 --- a/tests/basictests/dashboard.sh +++ b/tests/basictests/dashboard.sh @@ -15,11 +15,15 @@ ODH_DASHBOARD_URL= os::test::junit::declare_suite_start "$MY_SCRIPT" +function check_crds() { + header "Checking for ODH Dashboard dependencies - CustomResourceDefinitions" + os::cmd::try_until_not_text "oc get crd odhdashboardconfigs.opendatahub.io" "NotFound" $odhdefaulttimeout $odhdefaultinterval +} + function check_resources() { header "Testing dashboard installation" os::cmd::expect_success "oc project ${ODHPROJECT}" os::cmd::try_until_text "oc get odh-dashboard odh-dashboard" "odh-dashboard" $odhdefaulttimeout $odhdefaultinterval - os::cmd::try_until_text "oc get crd odhdashboardconfigs " "odhdashboardconfigs" $odhdefaulttimeout $odhdefaultinterval os::cmd::try_until_text "oc get role odh-dashboard" "odh-dashboard" $odhdefaulttimeout $odhdefaultinterval os::cmd::try_until_text "oc get rolebinding odh-dashboard" "odh-dashboard" $odhdefaulttimeout $odhdefaultinterval os::cmd::try_until_text "oc get route odh-dashboard" "odh-dashboard" $odhdefaulttimeout $odhdefaultinterval @@ -67,6 +71,7 @@ function test_odh_dashboard_ui() { popd } +check_crds check_resources # Disabling the REST API check because it requires that the user account has cluster-admin permissions # This test should be re-enabled when https://github.com/opendatahub-io/odh-dashboard/issues/548 is resolved diff --git a/tests/resources/ods-ci/test-odh-dashboard-jupyterlab-notebook.robot b/tests/resources/ods-ci/test-odh-dashboard-jupyterlab-notebook.robot index fc3ea45b2..1fb5a35a8 100644 --- a/tests/resources/ods-ci/test-odh-dashboard-jupyterlab-notebook.robot +++ b/tests/resources/ods-ci/test-odh-dashboard-jupyterlab-notebook.robot @@ -26,7 +26,7 @@ Can Spawn Notebook # We need to skip this testcase if the user has an existing pod Fix Spawner Status Capture Page Screenshot - Spawn Notebook With Arguments image=s2i-generic-data-science-notebook + Spawn Notebook With Arguments image=jupyter-datascience-notebook Can Launch Python3 Smoke Test Notebook [Documentation] Execute simple commands in the Jupyter notebook to verify basic functionality